Suppress warnings caused by map([], ' "x" ') #259

Kuniwak · 2018-01-05T08:35:25Z

Before this patch, ProhibitUnnecessaryDoubleQuote report warnings caused by the code:

map([0, 1, 2], ' "x" ')
"                ^^^
"                Prefer single quoted strings (see Google VimScript Style Guide (Strings))

After this patch, Vint will suppress the warnings:

map([0, 1, 2], ' "x" ')
" (no warnings)

Discussion

This feature can be an option of ProhibitUnnecessaryDoubleQuote.
But I feel this option is useless. Because the following code is noisy:

map([0, 1, 2], ' ''x'' ')

thinca · 2018-01-08T08:48:10Z

map([0, 1, 2], ' \'x\' ')

Did you mean:

echo map([0, 1, 2], ' ''x'' ')

Kuniwak · 2018-01-10T05:29:39Z

@thinca You're right. I have the mistake.

EDIT: I fixed it.

Kuniwak added 3 commits January 5, 2018 16:27

Reproduce the map() problem

4825d9d

Fix test on Python 3.5+

f209fc0

pytest-dev/pytest#744

First aid for false positives caused by map([], '""')

967fa32

Kuniwak changed the title ~~WIP: Fix false positives caused by map)~~ WIP: Fix false positives caused by map([], '""') Jan 5, 2018

Kuniwak added 2 commits January 5, 2018 17:53

Test nested map such as map([], 'map([], "v:val")')

f643f04

Make performance better (but not measured)

692fdc4

Kuniwak changed the title ~~WIP: Fix false positives caused by map([], '""')~~ Fix false positives caused by map([], '""') Jan 5, 2018

Upgrade Vital.vim

fa7363e

Kuniwak changed the title ~~Fix false positives caused by map([], '""')~~ Suppress warnings caused by map([], ' "x" ') Jan 5, 2018

Kuniwak self-assigned this Jan 5, 2018

Kuniwak requested a review from Coacher January 5, 2018 09:28

Kuniwak merged commit 4b4bc15 into master Jun 18, 2018

Kuniwak deleted the fix-map-string branch June 18, 2018 07:01

Kuniwak mentioned this pull request Jun 19, 2018

Ready to be v0.3.19 #277

Merged