8000 expand `~` in saml_cache_file config field by rrotter · Pull Request #1386 · Versent/saml2aws · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

expand ~ in saml_cache_file config field #1386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 13, 2025

Conversation

rrotter
Copy link
Contributor
@rrotter rrotter commented Jan 24, 2025

currently setting a path like:

saml_cache_file  = ~/.aws/cache

results in the cache being created under a directory called ~ rather in $HOME.

This PR runs homedir.Expand on the configured path.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 23.07692% with 10 lines in your changes missing coverage. Please review.

Project coverage is 28.09%. Comparing base (99d6fe4) to head (958e9b1).
Report is 147 commits behind head on master.

Files with missing lines Patch % Lines
pkg/samlcache/samlcache.go 23.07% 7 Missing and 3 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1386       +/-   ##
===========================================
- Coverage   42.19%   28.09%   -14.11%     
===========================================
  Files          54       70       +16     
  Lines        6456    12545     +6089     
===========================================
+ Hits         2724     3524      +800     
- Misses       3283     8544     +5261     
- Partials      449      477       +28     
Flag Coverage Δ
unittests 28.09% <23.07%> (-14.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tinaboyce tinaboyce merged commit 36983fb into Versent:master Mar 13, 2025
8 checks passed
@tinaboyce
Copy link
Contributor

Thank you for your contribution! 🙇

@rrotter rrotter deleted the cache_path_fix branch May 2, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0