8000 Why is the shape/dimensions parameter date type of Broadcast OP int32_t ? · Issue #376 · VeriSilicon/TIM-VX · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Why is the shape/dimensions parameter date type of Broadcast OP int32_t ? #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MESeraph opened this issue Apr 26, 2022 · 2 comments
Closed

Why is the shape/dimensions parameter date type of Broadcast OP int32_t ? #376

MESeraph opened this issue Apr 26, 2022 · 2 comments
Assignees
@chxin66
Milestone
22Q3_rel

Comments

@MESeraph
Copy link
Contributor

Screen Shot 2022-04-25 at 2 10 40 PM

The shape/dimensions parameter data type of Boardcast is `int32_t`. It will be convert to `uint32_t` by Boardcat contruct function. Why not set parameter to `uint32_t` type?
@sunshinemyson
Copy link
Contributor

@MESeraph ，

thanks for repor T，we will check

@sunshinemyson sunshinemyson added this to the 22Q3_rel milestone Sep 28, 2022
@chxin66
Copy link
Contributor
chxin66 commented Oct 21, 2022

done

8000

chenfeiyue-cfy added a commit to chenfeiyue-cfy/TIM-VX that referenced this issue Oct 28, 2022
@chenfeiyue-cfy
Fixed unreasonable type of parameter in broadcast
1c9062c 
Change type of shape from int to uint & add ut for broadcast
From github issue VeriSilicon#376

Type: Code Improvement
Signed-off-by: Feiyue Chen <Feiyue.Chen@verisilicon.com>
@chenfeiyue-cfy chenfeiyue-cfy mentioned this issue Oct 28, 2022
Merged
chenfeiyue-cfy added a commit to chenfeiyue-cfy/TIM-VX that referenced this issue Jan 3, 2024
@chenfeiyue-cfy
Fixed unreasonable type of parameter in broadcast
565ba0a 
Change type of shape from int to uint & add ut for broadcast
From github issue VeriSilicon#376
Define opversion to avoid incompatibility with upper level software

Type: Code Improvement
Signed-off-by: Feiyue Chen <Feiyue.Chen@verisilicon.com>
chenfeiyue-cfy added a commit to chenfeiyue-cfy/TIM-VX that referenced this issue Jan 4, 2024
@chenfeiyue-cfy
Fixed unreasonable type of parameter in broadcast
2c29038 
Change type of shape from int to uint & add ut for broadcast
From github issue VeriSilicon#376
Define opversion to avoid incompatibility with upper level software

Type: Code Improvement
Signed-off-by: Feiyue Chen <Feiyue.Chen@verisilicon.com>
sunshinemyson pushed a commit that referenced this issue Jan 4, 2024
@chenfeiyue-cfy
Fixed unreasonable type of parameter in broadcast (#505)
54b9c67 
Change type of shape from int to uint & add ut for broadcast
From github issue #376
Define opversion to avoid incompatibility with upper level software

Type: Code Improvement

Signed-off-by: Feiyue Chen <Feiyue.Chen@verisilicon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chxin66 chxin66

Labels
None yet
Projects
None yet
Milestone
22Q3_rel
Development

No branches or pull requests
3 participants
@sunshinemyson @MESeraph @chxin66
0