[Rust]is_model_loadedを実装した #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwerty2501
commented
Jun 7, 2022
crates/voicevox_core/src/internal.rs
Outdated
Comment on lines
57
to
67
| pub fn is_model_loaded(speaker_id: i64) -> bool { | ||
| unimplemented!() | ||
| if let Some(status) = STATUS.lock().unwrap().as_ref() { | ||
| status.is_model_loaded(speaker_id as usize) | ||
| } else { | ||
| false | ||
| } | ||
| } |
There was a problem hiding this comment.
この関数について、グローバル変数の状態によってテスト結果が変わってしまうためテストが書きにくい状態になっています
There was a problem hiding this comment.
オブジェクト指向的にはis_model_loadedもSTATUSも同じクラスに含めてしまってシングルトンクラスとしちゃえばテストも書けそうなのですが、Rustだとどうするのが良いんだろう。
There was a problem hiding this comment.
ちょっと意図が読めないのですが、
シングルトンもグローバル変数もstatic領域に配置してることには変わりないので他のテストの影響を受けてしまうのは変わらないと思います
There was a problem hiding this comment.
static変数を使う部分をテストすることはできないと諦めて、static変数を使う部分と処理をするコードに分けて、後者だけテストするのを意図しています。
その方法の１つがクラス化＆シングルトンかなと思った次第です。
#150 (comment) と似ています。
There was a problem hiding this comment.
やるにしてもまとめてやったほうがよさそうですね
Hiroshiba
approved these changes
Jun 7, 2022
d3f4e84 to
845a491
Compare
43 tasks
qwerty2501
added a commit
to qwerty2501/voicevox_core
that referenced
this pull request
Jul 23, 2022
* is_model_loadedを実装した * is_model_loadedに渡す数値をspeaker_idではなくmodel_indexにした
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
id_model_loaded関数を実装しました
関連 Issue
refs #128
その他