8000 fix(compatible-engine): `load_model`が"reinit"できるように直す by qryxip · Pull Request #1089 · VOICEVOX/voicevox_core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(compatible-engine): load_modelが"reinit"できるように直す #1089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

qryxip
Copy link
Member
@qryxip qryxip commented May 27, 2025

内容

/initialize_speaker?skip_reinit=falseでの"reinit"ができなくなっていたので、できるようにする。

関連 Issue

その他

Before:
image

After:
image

Copy link
Member
@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

これ一応確認なんですけど、COREは0.16.0では(非公開APIの)compatible_engineでのみ、load_modelがreinitできないように破壊的変更が入ってしまっていた、という感じですかね!
であればこの動作が正しそう!気づいてくださってありがとうございます!!

@qryxip qryxip merged commit 6d8b93a into VOICEVOX:main May 27, 2025
28 checks passed
@qryxip qryxip deleted the pr/fix-compatible-engine-enable-load-model-to-reinit branch May 27, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0