-
Notifications
You must be signed in to change notification settings - Fork 123
feat: Java APIのPC用ビルドを追加 #764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ちょっとちゃんとわかってないですがほぼLGTMかなと!!
Co-authored-by: Hiroshiba <hihokaruta@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
私からは特にありません。LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ほぼLGTMです!!
とやかく言っちゃってすみません!
良いコードになっていると感じました!!
追従をするので一旦Draft... |
このPRって今どういう状態なんでしたっけ…? (追従ですが、今だと少なくとも「DirectML版」と「CUDA版」という概念は消失してそう) |
完全に覚えてないですね...とりあえず追従します |
手元で通ったのでdraft外します:https://github.com/sevenc-nanashi/voicevox_core/releases |
Co-authored-by: Ryo Yamashita <qryxip@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
あーーーー |
内容
タイトル通りです。
download-artifactがv4になってpattern指定できるようになったのでリファクタついでに。
関連 Issue
(なし)
その他
サンプル:https://github.com/sevenc-nanashi/voicevox_core/actions/runs/8419271673