Added support for -ffile-prefix-map argument #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
385b1c6 to
102d067
Compare
102d067 to
3af7cde
Compare
3af7cde to
947e3ea
Compare
artem
reviewed
Oct 21, 2024
Comment on lines
+75
to
+79
| for i := 0; i < len(cxxArgs); i++ { | ||
| cxxArg := FilePrefixMapOption(cxxArgs[i], session.client.workingDir) | ||
|
|
||
| cxxCmdLine = append(cxxCmdLine, cxxArg) | ||
| } |
There was a problem hiding this comment.
Does not handle the case where the client does not specify -ffile-prefix-map
P.S. Search seems to have quadratic complexity, but since cmdline is not explected to be long, it might be not an issue...
internal/server/compiler-options.go
Outdated
| if strings.Contains(cxxArg, prefixMapOption) { | ||
| parts := strings.Split(cxxArg, "=") | ||
| if len(parts) >= 2 && path.IsAbs(parts[1]) { | ||
| parts[1] = replaced + parts[1] |
There was a problem hiding this comment.
parts[1] = path.Join(replaced, parts[1])947e3ea to
3da9dab
Compare
3da9dab to
a0fd38e
Compare
Danil42Russia
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.