8000 improvement clang support: normalization of paths for isystem by troy4eg · Pull Request #23 · VKCOM/nocc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

improvement clang support: normalization of paths for isystem #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2024
Merged

improvement clang support: normalization of paths for isystem #23

merged 1 commit into from
Aug 27, 2024

Conversation

troy4eg
Copy link
Contributor
@troy4eg troy4eg commented Jul 10, 2024 •
edited
Loading

We use $CXX -Wp,-v -x c++ /dev/null -fsyntax-only to obtain the paths where we can search for system header files. For the clang compiler, the paths appear as follows:

 /usr/bin/../lib/gcc/aarch64-linux-gnu/10/../../../../include/c++/10
 /usr/bin/../lib/gcc/aarch64-linux-gnu/10/../../../../include/aarch64-linux-gnu/c++/10
 /usr/bin/../lib/gcc/aarch64-linux-gnu/10/../../../../include/c++/10/backward
 /usr/lib/llvm-18/lib/clang/18/include
 /usr/local/include
 /usr/include/aarch64-linux-gnu
 /usr/include

As we can see, the first three paths are not absolute. This means that in order to access the "/usr/bin/../lib/" path on the nocc server, we need a directory called "/usr/bin" within the source prefix directory, but we do not have it. As a result, it will skip these paths.

I think the best solution is to normalize the paths provided by the compiler.

@troy4eg troy4eg added the bug Something isn't working label Jul 10, 2024
@troy4eg troy4eg self-assigned this Jul 10, 2024
@troy4eg troy4eg force-pushed the troy4eg/improvement_clang_support branch from 72be8c5 to f46ac13 Compare August 27, 2024 16:10
@troy4eg troy4eg merged commit b1f7bb3 into master Aug 27, 2024
@troy4eg troy4eg deleted the troy4eg/improvement_clang_support branch August 27, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Danil42Russia Danil42Russia Danil42Russia approved these changes

Assignees

@troy4eg troy4eg

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@troy4eg @Danil42Russia
0