8000 initial localization support without relying on any external libraries by jincio92 · Pull Request #99 · VERT-sh/VERT · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

initial localization support without relying on any external libraries #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

initial localization support without relying on any external libraries #99

wants to merge 1 commit into from

Conversation

jincio92
Copy link
@jincio92 jincio92 commented Jun 4, 2025

Summary

This pull request introduces initial support for localization (i18n) without relying on any external libraries.

Details

  • Text in the new component is now pulled from a simple localization setup (no external libraries used).
  • Added the Language selection in the Settings page.
  • The implementation is minimal and self-contained to avoid introducing wide-ranging changes.
  • I aimed to follow the project's current patterns and avoid assumptions about future architecture.

Motivation

Adding localization makes the app more accessible to non-English (I'm Italian) speakers. This PR aims to sets up the basic structure so other contributors can easily add additional languages. I kept the scope limited to avoid making a massive PR — especially since I'm still learning the project's conventions.

Notes

  • This PR implements only the translate provider an a couple of keys to test the functioning since i thought that
  • Currently includes translation keys only for the new Language selector component.
  • I tried to keep existing functionality intact and tried to follow the pattern used in the project — happy to adjust things based on your feedback.
  • Open to feedback on naming, structure, or whether this aligns with the project's approach to i18n.
  • This is my first contribution to the project, so please let me know if there's anything I should change or align better with your standards.

Future Considerations

If this direction is approved, I’d be happy to help expand localization support across the rest of the app in future PRs.

First-time Contributor

This is my first contribution to this project. Thank you in advance for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jincio92
0