[MLA-1912] Move Match3 to com.unity.ml-agents #5259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
April 14, 2021 09:45
chriselion
commented
Apr 14, 2021
| @@ -18,8 +18,7 @@ The following table describes the package folder structure: | |||
| | _Runtime_ | Contains core C# APIs for integrating ML-Agents into your Unity scene. | | |||
| | _Tests_ | Contains the unit tests for the package. | | |||
|
|
|||
| The Runtime directory currently contains three features: | |||
There was a problem hiding this comment.
The count was wrong before :) It would be correct now, but made it more generic.
There was a problem hiding this comment.
I made the exact same change in my PR :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Move the match3 integration and update the docs.
Note I need to move the public sensor and actuator components to private, add properties, and add custom editors. I'll do that in a later PR, just want to get the move done now.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
Types of change(s)
Checklist
Other comments