Provide feesAccrued to afterLiquidity Hooks #853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saucepoint
commented
Aug 27, 2024
test/CustomAccounting.t.sol
Outdated
Comment on lines
353
to
355
| // Assert that the hook took the fee revenue | ||
| assertApproxEqAbs(hookGain0, feeRevenue0, 1 wei); | ||
| assertApproxEqAbs(hookGain1, feeRevenue1, 1 wei); |
There was a problem hiding this comment.
it irks me that addLiquidity assertions arent as robust as the removeLiquidity ones, however this test is to confirm that feesAccrued is properly passed & used by the hook, so this is OK to me
the assertions for addLiquidity were tricky because of autocompounding + wei imprecision
|
Forge code coverage:
|
hensha256
reviewed
Aug 28, 2024
| 292858 |
There was a problem hiding this comment.
wow this snapshot name is ocnfusing... not your fault but what is "create"?? add?
There was a problem hiding this comment.
looks like its the first cold write of modifyLiquidity
hensha256
reviewed
Aug 29, 2024
src/interfaces/IHooks.sol
Outdated
| @@ -84,7 +86,8 @@ interface IHooks { | |||
| /// @param sender The initial msg.sender for the remove liquidity call | |||
| /// @param key The key for the pool | |||
| /// @param params The parameters for removing liquidity | |||
| /// @param delta The caller's balance delta after removing liquidity | |||
| /// @param delta The caller's balance delta after removing liquidity; the sum of principal delta and fees accrued | |||
There was a problem hiding this comment.
principal delta, fees accrued, and hook delta
hensha256
previously approved these changes
Aug 30, 2024
hensha256
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #587
Description of changes
after{Add|Remove}Liquidity hooks now receive
feesAccruedalongsidecallerDelta, wherecallerDelta = principal + feesAccruedAdded a test hook where all feesAccrued is taken, to validate the data is provided correctly