Optimize price calculation in TickMath.getSqrtPriceAtTick
#664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d7a7d9f to
88d8f92
Compare
The way the 'price' variable is calculated within the TickMath library has been significantly refactored. Previously, the variable was set through a ternary conditional statement. Now, a more intricate assembly logic is used, which involves shifting, AND operations, and masking. Apart from the improved readability, this change also aims to optimize the math operations for 'price' calculation.
88d8f92 to
9bebbae
Compare
hensha256
reviewed
May 21, 2024
| // or price = int(2**128 / sqrt(1.0001)) if (absTick & 0x1) else 1 << 128 | ||
| uint256 price; | ||
| assembly { | ||
| price := xor(shl(128, 1), mul(xor(shl(128, 1), 0xfffcb933bd6fad37aa2d162d1a594001), and(absTick, 0x1))) |
There was a problem hiding this comment.
does the optimiser deal with cutting down this line? theres lots of things it knows it advance
xor(shl(128, 1), 0xfffcb933bd6fad37aa2d162d1a594001)
shl(128, 1)
There was a problem hiding this comment.
Yes. The compiler optimizer is able to reduce literal math expressions.
hensha256
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot
2B05
be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #273.
Related Issue
Which issue does this pull request resolve?
Description of changes
The way the 'price' variable is calculated within the TickMath library has been significantly refactored. Previously, the variable was set through a ternary conditional statement. Now, a more intricate assembly logic is used, which involves shifting, AND operations, and masking. Apart from the improved readability, this change also aims to optimize the math operations for 'price' calculation.