Pool.State Library (extsload) #579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forge code coverage:
|
|
I actually think we are probably almost ready for this change cause I don't think many of the open PRs change storage slots. Is it ready for review? |
|
@snreynolds the library is ready but still need to work the tests / remove the native getters & replace them with the library |
Signed-off-by: saucepoint <saucepoint@protonmail.com>
saucepoint
commented
Apr 30, 2024
hensha256
reviewed
May 8, 2024
|
oops still blocked. #635 has a fix for too many rejected fuzz runs, so we'll merge that before this ones ready |
hensha256
reviewed
May 13, 2024
snreynolds
reviewed
May 14, 2024
hensha256
reviewed
May 14, 2024
hensha256
reviewed
May 14, 2024
rustybera
suggested changes
May 14, 2024
* Add exttload to read transient storage from outside the contract * regenerate snapshots * Separate Extsload and Exttload * reduce amount of cases where vm.assume is used to reduce rejected inputs in high intensity fuzzing * make variable public * adjust natspec for exttload * Move isUnlocked, getNonzeroDeltaCount and currencyDelta view functions to pool state library * Don't bound swap amount to liquidity * Don't revert within the view function * regenerate gas snapshots * regenerate gas snapshots * regenerate gas snapshot for getting reserves * adjust comment to reflect new behaviour * include library code in gas snapshot * make slots bytes32 * rename PoolStateLibrary to StateLibrary * Separate transient and storage state libraries * adjust naming of test file * adjust comments to reflect new behaviour * Add sparse exttload * regenerate gas snapshots
hensha256
reviewed
May 14, 2024
hensha256
reviewed
May 14, 2024
hensha256
reviewed
May 14, 2024
…tTickInfo == getTickLiquidity
hensha256
reviewed
May 14, 2024
gretzke
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #278
Description of changes
Added a library (
PoolStateLibrary) for nested storage slots with extsload