8000 Move codecov upload to a separate job by dopplershift · Pull Request #3232 · Unidata/MetPy · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Move codecov upload to a separate job #3232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

dopplershift
Copy link
Member
@dopplershift dopplershift commented Oct 17, 2023

Description Of Changes

Switch CodeCov upload to use its own job on GitHub Actions rather than as a step after running tests. This effectively batches the upload after running the Conda/PyPI tests. This should reduce the number of calls, putting less stress on the system (the error is about API calls) and result in fewer opportunities to fail. It also makes it easier to retry just the upload with no need to re-run the tests.

Inspired by cylc/cylc-flow#5459.

@dopplershift dopplershift added Area: Infrastructure Pertains to project infrastructure (e.g. CI, linting) Type: Enhancement Enhancement to existing functionality labels Oct 17, 2023
@dopplershift dopplershift requested a review from a team as a code owner October 17, 2023 19:19
@dopplershift dopplershift requested review from dcamron and removed request for a team October 17, 2023 19:19
@dopplershift dopplershift force-pushed the codecov-jobs branch 2 times, most recently from e351d92 to 928df0a Compare October 17, 2023 19:50
This should reduce the number of calls, putting less stress on the
system and resulting in fewer opportunities to fail. It also makes it
easier to retry just the upload with no need to re-run the tests.
Copy link
Member
@dcamron dcamron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big fan of this 👍

@dcamron dcamron merged commit e149219 into Unidata:main Oct 17, 2023
@github-actions github-actions bot added this to the October 2023 milestone Oct 17, 2023
@dopplershift dopplershift deleted the codecov-jobs branch October 17, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Infrastructure Pertains to project infrastructure (e.g. CI, linting) Type: Enhancement Enhancement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0