Added std_logic_vector version of check_value_in_range(). #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I assume here you're planning to always assume an slv is unsigned? if so, then maybe use "unsigned(value)" in the if check? your current implementation will pass for: is this your intention? if so, write something about it in a comment above the function. I will also point out that the "sanity check" will only work for unsigned (but you write that this is your intention). If the user assumes signed when entering the values they can pass the sanity check with: max_value("1000" or -8) < min_value("0111" or 7), since these are assumed to be unsigned. maybe add a comment to the sanity error that the slv is assumed to be unsigned, and mention it in the actual msg on error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functions and procedures for std_logic_vector versions of check_value_in_range(). Avoids having to convert std_logic_vector to unsigned before calling the function.