8000 "Open Link in New Tab" doesn't redirect new tab. · Issue #86 · URLAutoRedirector/URLAutoRedirector · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

"Open Link in New Tab" doesn't redirect new tab. #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
boyesm opened this issue Mar 8, 2023 · 5 comments
Open

"Open Link in New Tab" doesn't redirect new tab. #86

boyesm opened this issue Mar 8, 2023 · 5 comments

Comments

@boyesm
Copy link
boyesm commented Mar 8, 2023
  • [ x ] I believe this to be a bug, not a question about using URL Auto Redirector.

My OS

  • [ x ] I am on (or have tested on) macOS 10+

My Chrome Version

110.0.5481.177 (Official Build) (arm64)

Bug / My Reproduction Steps

In my environment, when:

  1. I use the "Open Link in New Tab" right click option in Google Chrome
  2. The new tab is a link that should be redirected to another page according to set rules
  3. I remain in the same tab (don't change tabs)

The new tab that is opened does not redirect. Instead it seems that the active tab refreshes.

For example, I'm using this extension to redirect youtube.com to a certain playlist on youtube. However, when I right click on the YouTube icon and click "Open Link in New Tab", the new tab doesn't redirect at all.

@fatkdog
Copy link
fatkdog commented Jun 18, 2023

I an experiencing this same issue.

An example that can be reproduced, create the following filter.
(It's a simple "remove junk from amazon" pattern)

https?://(www\.)?amazon.com/(([^/]+)/)?(dp/|gp/product/)([^?/]+).*
goes to:
https://www.amazon.com/dp/$5/
regex

Then do a search on amazon and try and open any item in a new tab.

Depending on the option you have chosen:
1: Redirect in new tab
OR
2: Redirect in current tab

it will either
1: open the item in a new tab that is NOT redirected and then open a second new tab that IS redirected
OR
2: open the item in a new tab that is NOT redirected and then redirect the current tab (the search results) to the item you tried to open in the new tab with the correct pattern applied.

This is specifically an "open in new tab" issue.
I notice it on amazon because I like to open a lot of tabs with each item I am comparing.

Possibly the order of reading the url is too early. Like it should wait to read the url until the page loads, instead it reads the url first?
This could also explain why it doesn't redirect on page refresh.
Say I have a filter that is disabled and I load a page, then I enable the filter, then try and refresh the page. It doesn't redirect upon reload. I imagine intended behavior is for a page to redirect upon reload if a pattern is matched.
It seems to me it may need to have the time it read the url adjusted. Maybe a different trigger for pattern matching.

hope my info will help.
ty!

@crispgm
Copy link
Member
crispgm commented Jun 19, 2023

@fatkdog Hello, I am sorry that you encountered such issues. UAR uses loading event of tabs updated listener to capture URL. So it would redirect only if the page have started to load.

@zengzhaocheng
Copy link

Same on Windows

@fatkdog
Copy link
fatkdog commented Aug 30, 2023

Same on Windows

It is a shame. Until this issue is fixed the extension is unusable.

@fatkdog
Copy link
fatkdog commented Aug 30, 2023

@fatkdog Hello, I am sorry that you encountered such issues. UAR uses loading event of tabs updated listener to capture URL. So it would redirect only if the page have started to load.

@crispgm Does what you explain mean the current tab has it's own hidden reload action specifically when it spawns a new tab?

Is that why the "Open in New Tab" right click browser action breaks UAR? Like when I right click a link to "Open in New Tab" why does UAR modify the current tab I am in? Does that current original tab also trigger it's own "loading event" when it spawns the new tab?

I never notice the current tab reloading when a new tab is opened from it, it stays the same, yet, it is still having it's URL modified by UAR. I suppose it is possible it is reloading in a hidden way that I can not see.

Please tell me if I can help. If there is any info I can give please let me know. ty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
0