8000 ci: add release action by alvarosabu · Pull Request #820 · Tresjs/tres · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ci: add release action #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

ci: add release action #820

wants to merge 6 commits into from

Conversation

alvarosabu
Copy link
Member

No description provided.

@alvarosabu alvarosabu added the p1-chore Doesn't change end-user code behavior (priority) label Sep 5, 2024
Copy link
netlify bot commented Sep 5, 2024

Deploy Preview for tresjs-docs ready!

Name Link
🔨 Latest commit 08e75f1
🔍 Latest deploy log https://app.netlify.com/sites/tresjs-docs/deploys/66db04e727514d000856c40a
😎 Deploy Preview https://deploy-preview-820--tresjs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
pkg-pr-new bot commented Sep 5, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@tresjs/core@820

commit: 08e75f1

- name: Initialize Git User
run: |
git config user.name "${GITHUB_ACTOR}"
git config user.email "alvaro.saburido@gmail.com"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My suggestion would be to pack the user.email also in an env variable or secret, that way if in the future you want to change it or maybe us an organisation email (github(at).tresjs.org) or something else you can easily change it without having to update the code.

on:
pull_request:
push:
branches: [main]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure I guess you don't want to always execute a full release when a merge on master is done, probably something like an insider release with a hash could be an idea.

We have implemented a workflow in our project that creates an insider-release after every merge to main. It's far from perfect but could be an option:
https://github.com/six-group/six-webcomponents/blob/main/.github/workflows/insider-release.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change end-user code behavior (priority)
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants
0