-
-
Notifications
You must be signed in to change notification settings - Fork 143
ci: add release action #820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for tresjs-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
commit: |
- name: Initialize Git User | ||
run: | | ||
git config user.name "${GITHUB_ACTOR}" | ||
git config user.email "alvaro.saburido@gmail.com" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My suggestion would be to pack the user.email also in an env variable or secret, that way if in the future you want to change it or maybe us an organisation email (github(at).tresjs.org) or something else you can easily change it without having to update the code.
on: | ||
pull_request: | ||
push: | ||
branches: [main] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure I guess you don't want to always execute a full release when a merge on master is done, probably something like an insider release with a hash could be an idea.
We have implemented a workflow in our project that creates an insider-release after every merge to main. It's far from perfect but could be an option:
https://github.com/six-group/six-webcomponents/blob/main/.github/workflows/insider-release.yml
No description provided.