Add mypy
#364
Closed
Add mypy
#364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Calling problem.solve should always populate w.value as a side-effect, making its type be np.ndarray instead of np.ndarray | None
…ricks, and add a comment
Codecov ReportAll modified and coverable lines are covered by tests ✅
🚀 New features to boost your workflow:
|
|
@PierreQuinton you can already look at some of these, but for the most complex ones, I would love to discuss them in a live coding session with you. |
|
Closing this now that all the PRs have been extracted for individual review and merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is just to give an overview of the changes related to the addition of mypy. I will probably break this into smaller PRs when it's completed. To install mypy and run it locally, do:
#365: Add mypy action
#366: Fix type of _check_losses_are_scalar
#367:
#368: Use new variables in backward and mtl_backward when changing type
#369:
#372:
#370:
#371: Ignore type error in get_leaf_tensors and add comment
#374: Update Conjunction.call to make its typing correct (#379 is better)
#375: Change OrderedSet to compose with OrderedDict instead of inheriting from it