Fixes #41 an Article with N Comments #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
- use heritage benefits onto CreativeWork, Sculpture, Article, Comment
- allow to set multiple comments to an Article (or CreativeWork)
- add ld json generation and asserts on each not null property
- use heritage benefits onto CreativeWork, Sculpture, Article, Comment - allow to set multiple comments to an Article (or CreativeWork) - add ld json generation and asserts on each not null property
87b829f to
f91f99d
Compare
Closed
- Person extend Things - Place extend Things - add attributes with unit tests - improve unit test assert method
f91f99d to
bcc21da
Compare
|
up! 🙃 could you please tell me your feedback about this PR ? |
|
please @Torann review me :) |
Add back a few missing properties
Ugh sorry, you had this correct
Linting
Linting
Linting
|
Looks great. I just fixed a few linting issues :-) |
boly38
added a commit
to geokrety/geokrety-website
that referenced
this pull request
Oct 29, 2018
- following #7 initial LdJson SEO feature - increase ld-json version to 0.0.14 following Torann/json-ld#42 - use new fields from 0.0.14 (publisher, lang, date) - add konkret dedicated ldjson helper and test - use full url for 'sameAs' field, that fixes #121 - manual tests with google tool https://search.google.com/structured-data/testing-tool/u/0/?hl=fr - fix phpunit tests - improve irc notifications details - fix codacy
boly38
added a commit
to geokrety/geokrety-website
that referenced
this pull request
Oct 30, 2018
- following #7 initial LdJson SEO feature - increase ld-json version to 0.0.14 following Torann/json-ld#42 - use new fields from 0.0.14 (publisher, lang, date) - add konkret dedicated ldjson helper and test - use full url for 'sameAs' field, that fixes #121 - manual tests with google tool https://search.google.com/structured-data/testing-tool/u/0/?hl=fr - fix phpunit tests - improve irc notifications details - fix codacy
boly38
added a commit
to geokrety/geokrety-website
that referenced
this pull request
Oct 30, 2018
- following #7 initial LdJson SEO feature - increase ld-json version to 0.0.14 following Torann/json-ld#42 - use new fi 6BD0 elds from 0.0.14 (publisher, lang, date) - add konkret dedicated ldjson helper and test - use full url for 'sameAs' field, that fixes #121 - manual tests with google tool https://search.google.com/structured-data/testing-tool/u/0/?hl=fr - fix phpunit tests - improve irc notifications details - fix codacy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.