8000 build: bump ccrestoration to v0.2.1 by routineLife1 · Pull Request #28 · Tohrusky/Final2x-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

build: bump ccrestoration to v0.2.1 #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 14, 2024
Merged

build: bump ccrestoration to v0.2.1 #28

merged 3 commits into from
Dec 14, 2024

Conversation

routineLife1
Copy link
Contributor
@routineLife1 routineLife1 commented Dec 14, 2024 •
edited by sourcery-ai bot
Loading

Summary by Sourcery

Add new model options and update the pretrained model generation script to include additional model types. Bump the ccrestoration dependency to version 0.2.1.

New Features:

  • Add new model options including SRCNN, HAT, and HAT_Real_GAN to the ModelOptions script.

Enhancements:

  • Update the gen_pretrained_model_name.py script to include new model types DAT, HAT, and SRCNN.

Build:

  • Bump ccrestoration dependency version to 0.2.1 in pyproject.toml.

@sourcery-ai Sourcery AI
Copy link
sourcery-ai bot commented Dec 14, 2024 •
edited
Loading

Reviewer's Guide by Sourcery

This PR updates the ccrestoration dependency to version 0.2.1 and adds support for new model types (SRCNN and HAT) in the model options. The changes include adding new model configurations and reordering the model type list.

Class diagram for updated ModelOptions

classDiagram
    class ModelOptions {
        +String label
        +String value
    }

    ModelOptions : +DAT_light_3x
    ModelOptions : +DAT_light_4x
    ModelOptions : +DAT_APISR_GAN_generator_4x
    ModelOptions : +SRCNN_2x
    ModelOptions : +SRCNN_3x
    ModelOptions : +SRCNN_4x
    ModelOptions : +HAT_S_2x
    ModelOptions : +HAT_S_3x
    ModelOptions : +HAT_S_4x
    ModelOptions : +HAT_2x
    ModelOptions : +HAT_3x
    ModelOptions : +HAT_4x
    ModelOptions : +HAT_Real_GAN_sharper_4x
    ModelOptions : +HAT_Real_GAN_4x
    ModelOptions : +HAT_ImageNet_pretrain_2x
    ModelOptions : +HAT_ImageNet_pretrain_3x
    ModelOptions : +HAT_ImageNet_pretrain_4x
    ModelOptions : +HAT_L_ImageNet_pretrain_2x
    ModelOptions : +HAT_L_ImageNet_pretrain_3x
    ModelOptions : +HAT_L_ImageNet_pretrain_4x

    note for ModelOptions "New models SRCNN and HAT added"
Loading

Class diagram for updated gen_pretrained_model_name.py

classDiagram
    class ModelType {
        +RealESRGAN
        +DAT
        +HAT
        +RealCUGAN
        +EDSR
        +SwinIR
        +SCUNet
        +SRCNN
    }

    note for ModelType "Reordered and added new model types: SRCNN and HAT"
Loading

File-Level Changes

Change Details Files
Added new model options for SRCNN and HAT models
  • Added SRCNN model options for 2x, 3x, and 4x upscaling
  • Added HAT model options including standard, small, GAN variants, and ImageNet pretrained versions
  • Added HAT_L ImageNet pretrained models for 2x, 3x, and 4x upscaling
 scripts/ModelOptions.ts
Updated model type configuration order and added new types
  • Added HAT and SRCNN to the list of supported model types
  • Reordered the model types list with DAT moved up in the sequence
 scripts/gen_pretrained_model_name.py
Updated dependency version
  • Bumped ccrestoration package version from 0.1.2 to 0.2.1
 pyproject.toml
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Dec 14, 2024
View reviewed changes
Copy link
@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @routineLife1 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Tohrusky Tohrusky merged commit 69ad444 into Tohrusky:main Dec 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@routineLife1 @Tohrusky
0