cleanup: Don't use `memcpy` to cast arbitrary `struct`s to `uint8_t[]`. #2684

iphydf · 2024-02-12T10:47:20Z

We can memcpy integral types and array types. There's no need to directly memcpy into or from struct types.

This change is

We can memcpy integral types and array types. There's no need to directly memcpy into or from struct types.

codecov · 2024-02-12T10:56:53Z

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c71567d) 72.94% compared to head (623e3ee) 73.11%.

Files	Patch %	Lines
toxcore/network.c	75.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2684      +/-   ##
==========================================
+ Coverage   72.94%   73.11%   +0.17%     
==========================================
  Files         148      148              
  Lines       30486    30486              
==========================================
+ Hits        22238    22291      +53     
+ Misses       8248     8195      -53

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Green-Sky · 2024-02-12T12:09:48Z

I thought we ran autotests on ipv6 too?

iphydf · 2024-02-12T20:15:42Z

I thought we ran autotests on ipv6 too?

I'm not sure we run those on CI. Why are you asking?

nurupo · 2024-02-13T04:43:48Z

Maybe this warning has something to do with it

iphydf added this to the v0.2.19 milestone Feb 12, 2024

iphydf marked this pull request as ready for review February 12, 2024 10:48

cleanup: Don't use memcpy to cast arbitrary structs to uint8_t[].

623e3ee

We can memcpy integral types and array types. There's no need to directly memcpy into or from struct types.

iphydf force-pushed the no-struct-bytes-cast branch from c18eb8e to 623e3ee Compare February 12, 2024 10:56

nurupo approved these changes Feb 13, 2024

View reviewed changes

pull-request-attention bot assigned iphydf Feb 13, 2024

toktok-releaser merged commit 623e3ee into TokTok:master Feb 13, 2024

iphydf deleted the no-struct-bytes-cast branch February 13, 2024 21:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cleanup: Don't use `memcpy` to cast arbitrary `struct`s to `uint8_t[]`. #2684

cleanup: Don't use `memcpy` to cast arbitrary `struct`s to `uint8_t[]`. #2684

cleanup: Don't use memcpy to cast arbitrary structs to uint8_t[]. #2684

Codecov Report

cleanup: Don't use `memcpy` to cast arbitrary `struct`s to `uint8_t[]`. #2684