cleanup: Ensure handler params are named after callback params. #2581
Conversation
4dedd4b to
ec098b9
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2581 +/- ##
==========================================
+ Coverage 66.84% 66.86% +0.02%
==========================================
Files 148 148
Lines 30332 30330 -2
==========================================
+ Hits 20274 20279 +5
+ Misses 10058 10051 -7 ☔ View full report in Codecov by Sentry. |
ec098b9 to
89957be
Compare
There was a problem hiding this comment.
First I had a chuckle at a variable named todo. Then I started reading further and fell into despair from the inconsistency of things.
After this PR is merged, some files, like groupav.c, will introduce "conference" that replaces "group", but not everywhere in the file since the PR does only very specific, low scope, edit. So you end up with "conference" being used in some places and "group" in others. Similar with "friend number" and "peer number". The PR didn't even edit the function docs for the functions it changed so that they match the updated function argument names -- they still talk about groups and friend numbers and not conferences and peer numbers. This leaves groupav.c in such an inconsistent naming convention state that I'm denying and not even reviewing the rest of the PR.
Reviewed 11 of 33 files at r1, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @iphydf)
toxav/groupav.h line 24 at r1 (raw file):
/** @brief Create and connect to a new toxav group. * * @return group number on success.
The documentation still says "group number" and refers to conferences as groups. This and other functions' documentation.
toxav/groupav.h line 34 at r1 (raw file):
* @retval -1 on failure. */ int join_av_groupchat(const Logger *log, Tox *tox, Group_Chats *g_c, uint32_t friendnumber, const uint8_t *data,
No friendnumber -> peernumber here?
toxav/groupav.h line 34 at r1 (raw file):
* @retval -1 on failure. */ int join_av_groupchat(const Logger *log, Tox *tox, Group_Chats *g_c, uint32_t friendnumber, const uint8_t *data,
No renaming this into join_av_conference()?
|
Welp, this got merged just as I was reviewing it. |
|
ah sorry about that. in general, the av code is not maintained as well as core. we are basically waiting with consistent larger changes for #1431 to be merged, but that wont happen until after 0.2.19. |
This change is