refactor: Pass this pointer as first param to s11n callbacks.
#2575
Conversation
2691e3c to
1c16b4c
Compare
|
Don't you love it when you write review comments, but don't click on the button to "add" them, and then click to submit the review thinking they would get added, like it works in Reviewable, but GitHub just erases all your comments, having to re-write them again as none are saved. Ugh. (The next worst thing, since in this case the comments are not lost at least, is adding comments by clicking on "Start a review", thinking than you actually initialized the review process and they are visible to anyone, with "pending" meaning that they haven't been resolved yet, but after several days of no one responding to them, you check the issue in a browser you are not logged in and you don't see any of your comments... yeah, fun). |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2575 +/- ##
==========================================
+ Coverage 66.75% 66.84% +0.08%
==========================================
Files 148 148
Lines 30328 30332 +4
==========================================
+ Hits 20246 20274 +28
+ Misses 10082 10058 -24 ☔ View full report in Codecov by Sentry. |
fd5f8cf to
b175548
Compare
fb910e8 to
7439214
Compare
This change is