cleanup: Make all .c files include the headers they need. #2505
Conversation
a0e2bf8 to
9d73ebb
Compare
9d73ebb to
e1a25e8
Compare
|
Wow, this is great. Is there a tool for this?
|
|
My bad, |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2505 +/- ##
==========================================
- Coverage 69.02% 68.95% -0.08%
==========================================
Files 89 89
Lines 27769 27772 +3
==========================================
- Hits 19167 19149 -18
- Misses 8602 8623 +21 ☔ View full report in Codecov by Sentry. |
|
It was completely manually, because |
e1a25e8 to
fad6e4e
Compare
|
How can I get these error messages from clang-tidy? Is there a specific check name I need to enable? |
|
Looks like this might be it https://clang.llvm.org/extra/clang-include-fixer.html |
|
It's |
There was a problem hiding this comment.
Reviewed 65 of 65 files at r1, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained
There was a problem hiding this comment.
Reviewed 4 of 65 files at r1.
Reviewable status:
toxcore/ccompat.c line 6 at r1 (raw file):
#include "ccompat.h" static_assert(sizeof(int) >= 4, "toxcore does not support 16-bit platform");
Missing an s?
toxcore/group_moderation.c line 461 at r1 (raw file):
const int packed_len = sanctions_list_pack(packed_data, sizeof(packed_data), sanction, 1, nullptr); if (packed_len <= SIGNATURE_SIZE) {
For clarity sake, SIGNATURE_SIZE used to be a size_t, making the cast necessary. Now it's an int so this change is okay.
This change is