8000 Restyle fix: potential freeing of an immutable static buffer by restyled-io[bot] · Pull Request #1949 · TokTok/c-toxcore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Restyle fix: potential freeing of an immutable static buffer #1949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Restyle fix: potential freeing of an immutable static buffer #1949

wants to merge 3 commits into from

Conversation

restyled-io[bot]
Copy link
@restyled-io restyled-io bot commented Feb 2, 2022 •
edited by robinlinden
Loading

A duplicate of #1948 with additional commits that automatically address
incorrect style, created by Restyled.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.

The following Restylers made fixes:

  • astyle

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Expand for example instructions 
    ```console
git remote add upstream https://github.com/TokTok/c-toxcore.git
git fetch upstream pull/<this PR number>/head
git merge --ff-only FETCH_HEAD
git push
```

NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.

Sorry if this was unexpected. To disable it, see our documentation.

This change is Reviewable

@auto-add-label auto-add-label bot added the bug Bug fix for the user, not a fix to a build script label Feb 2, 2022
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

nurup 8000 o and others added 3 commits February 1, 2022 22:41
@nurupo
Fix potential freeing of an immutable static buffer
2b24f46 
strerror_r() has two versions: GNU-specific and XSI-compliant. The XSI
version always stores the string in the provided buffer, but the GNU
version might store it in the provided buffer or it might use some
immutable static buffer instead. Since we always free the error string,
we might end up freeing the immutable static buffer.
@nurupo
Use the proper feature test macro for strerror_r
dcbe210 
As per the strerror_r man page.
@restyled-commits
Restyled by astyle
7e90d68
@restyled-io restyled-io bot force-pushed the restyled/pull-1948 branch from 706f1b7 to 7e90d68 Compare February 2, 2022 03:42
@restyled-io restyled-io bot closed this Feb 2, 2022
@restyled-io restyled-io bot deleted the restyled/pull-1948 branch February 2, 2022 03:50
@iphydf iphydf added this to the meta milestone Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Bug fix for the user, not a fix to a build script
Milestone
z-meta
Development

Successfully merging this pull request may close these issues.
4 participants
@CLAassistant @iphydf @nurupo @restyled-commits
0