10000 Restyle cleanup: Remove our only use of flexible array members in toxcore. by restyled-io[bot] · Pull Request #1911 · TokTok/c-toxcore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Restyle cleanup: Remove our only use of flexible array members in toxcore. #1911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Restyle cleanup: Remove our only use of flexible array members in toxcore. #1911

wants to merge 2 commits into from

Conversation

restyled-io[bot]
Copy link
@restyled-io restyled-io bot commented Jan 17, 2022 •
edited by iphydf
Loading

A duplicate of #1910 with additional commits that automatically address
incorrect style, created by Restyled.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.

The following Restylers made fixes:

  • astyle

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Expand for example instructions 
    ```console
git remote add upstream https://github.com/TokTok/c-toxcore.git
git fetch upstream pull/<this PR number>/head
git merge --ff-only FETCH_HEAD
git push
```

NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.

Sorry if this was unexpected. To disable it, see our documentation.

This change is Reviewable

@auto-add-label auto-add-label bot added the cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature. label Jan 17, 2022
iphydf and others added 2 commits January 17, 2022 01:35
@iphydf
cleanup: Remove our only use of flexible array members in toxcore.
ea5e198 
We still have them in toxav. That will need to be cleaned up later.
Flexible array members have very limited usefulness. In this particular
case, it's almost entirely useless. It confuses static analysers and is
yet one more C feature we need to understand and support. It is also the
only reason we need special support in tokstyle for calloc with a `+`
operator in the member size.
@restyled-commits
Restyled by astyle
7af273e
@restyled-io restyled-io bot force-pushed the restyled/pull-1910 branch from bec4850 to 7af273e Compare January 17, 2022 01:35
@restyled-io restyled-io bot closed this Jan 17, 2022
@restyled-io restyled-io bot deleted the restyled/pull-1910 branch January 17, 2022 01:36
@iphydf iphydf added this to the meta milestone Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature.
Milestone
z-meta
Development

Successfully merging this pull request may close these issues.
2 participants
@iphydf @restyled-commits
0