8000 Service discovery adds Nacos by MiaoShuYo · Pull Request #2268 · ThreeMammals/Ocelot · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Service discovery adds Nacos #2268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Service discovery adds Nacos #2268

wants to merge 2 commits into from

Conversation

MiaoShuYo
Copy link
@MiaoShuYo MiaoShuYo commented Mar 18, 2025 •
edited by raman-m
Loading

@raman-m raman-m mentioned this pull request Mar 18, 2025
Open
@raman-m
Copy link
Member
raman-m commented Mar 18, 2025 •
edited
Loading

Hi @MiaoShuYo,
Thank you for creating this pull request!

I have decided to manage separate repositories for each Ocelot extension package. Since your PR introduces a new service discovery type in Ocelot, I have created a repository specifically for this provider: Ocelot.Discovery.Nacos

Let's close this pull request and kindly go to the new repository to create a new pull request. Please don't push commits.
I have granted you Write permission for collaboration, and you should have received an invitation message in your email inbox. Let's continue development in the Ocelot.Discovery.Nacos repo.

Best regards,
Raman

@raman-m raman-m added proposal Proposal for a new functionality in Ocelot Service Discovery Ocelot feature: Service Discovery labels Mar 18, 2025
@raman-m
Copy link
Member
raman-m commented Mar 18, 2025 •
edited
Loading

Miao, could we keep this PR open to update the documentation later? I can't move documentation development to the new repository because our docs build targets this repository. Therefore, the plan is as follows:

  • Complete package development in Ocelot.Discovery.Nacos repository
  • Set up CI/CD and release the package, publishing it to NuGet
  • Finally, update the documentation in this repository to enable other users to read and use the newly developed package

Does this sound acceptable?

@raman-m raman-m marked this pull request as draft March 18, 2025 10:48
@MiaoShuYo
Copy link
Author

After building play I will write Wendan.

@raman-m
Copy link
Member
raman-m commented Mar 19, 2025

After building play I will write Wendan.

Sorry?

@MiaoShuYo
Copy link
Author

After building play I will write Wendan.

Sorry?

Sorry for the confusion, but I would like to say that after submitting the code, I will add documentation on how to use it.

8000
@raman-m raman-m mentioned this pull request Mar 19, 2025
Open
@raman-m raman-m force-pushed the develop branch 14 times, most recently from c216cdf to b458f0f Compare April 7, 2025 16:13
@raman-m raman-m force-pushed the develop branch 3 times, most recently from 045d3bb to af33cc2 Compare April 15, 2025 13:53
@raman-m raman-m force-pushed the develop branch 19 times, most recently from 908d84f to 0678e7a Compare April 19, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MiaoShuYo MiaoShuYo

Labels
proposal Proposal for a new functionality in Ocelot Service Discovery Ocelot feature: Service Discovery
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MiaoShuYo @raman-m
0