Add "class year" to pledge form #1007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9ae7c3d to
96d177e
Compare
TestingPledge FormMember List (default if blank) |
|
I would say this should not be added on the member list as it's a snapshot
in time out of the pledge form. We will not be updating it regularly so it
would just always be The class year you pledged as which we don't really
want.
…On Mon, Feb 17, 2025, 5:22 PM Pablo Pizzoro ***@***.***> wrote:
Testing Pledge Form
Screenshot.2025-02-17.at.5.16.56.PM.png (view on web)
<https://github.com/user-attachments/assets/948d3947-acee-4c4a-aeba-87ed6521387d>
Member List (default if blank)
Screenshot.2025-02-17.at.5.21.19.PM.png (view on web)
<https://github.com/user-attachments/assets/81c117e6-4bb8-4674-9ed1-8fee691d35b9>
—
Reply to this email directly, view it on GitHub
<#1007 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AATFXJY2BR6JKURRPZ2W72T2QJ4KTAVCNFSM6AAAAABXKLM6IWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRUGI3TAOJXGA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
[image: bull313]*bull313* left a comment (ThetaTau/CMT#1007)
<#1007 (comment)>
Testing Pledge Form
Screenshot.2025-02-17.at.5.16.56.PM.png (view on web)
<https://github.com/user-attachments/assets/948d3947-acee-4c4a-aeba-87ed6521387d>
Member List (default if blank)
Screenshot.2025-02-17.at.5.21.19.PM.png (view on web)
<https://github.com/user-attachments/assets/81c117e6-4bb8-4674-9ed1-8fee691d35b9>
—
Reply to this email directly, view it on GitHub
<#1007 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AATFXJY2BR6JKURRPZ2W72T2QJ4KTAVCNFSM6AAAAABXKLM6IWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRUGI3TAOJXGA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
This reverts commit 0bd6e6e.
96d177e to
74f2a95
Compare
|
Fixes #983 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#983
Description
Adds a class year (freshman, sophomore, junior, senior, senior +, graduate student, none) to the user model
Testing Instructions
Submit the pledge form - notice that there is a new field under "graduation year" called "class year". Submit to ensure field works with no harm