add 'balance --max-moves-per-osd' option #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheJJ
requested changes
Apr 16, 2025
There was a problem hiding this comment.
hey! great idea, this surely is useful.
i think the implementation can be optimized a bit :)
your code basically does explicit tracking, but this for example disregards movements that are un-done in the process. this also is something that changes during optimization, so it should be part of the simulated cluster state PGMappings.
so it would be better to add the query of planned OSD moves as a feature/new function to PGMappings.
the number of planned moves is simply
@lru_cache(max=...)
def get_osd_remaps_num(self, osdid: int):
return len(self._osd_pgs_up[osdid] ^ self._osd_pgs_acting[osdid])that can be returned from a cached function (which is cache-reset when a new move is recorded).
|
@TheJJ , thanks for the feedback! I'll look into optimizing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the option
--max-moves-per-osd=Nto thebalancecommand:Using this option ensures that the found movements would not cause the number of simultaneously ongoing moves per OSD to be greater than the given
MAX_MOVES_PER_OSD.This helps with making the movements more spread out across the cluster and avoiding overload of some OSDs to a point that it negatively affects clients. This may be useful on some heavily loaded mission critical clusters, especially when running on spinning drives.