8000 added an override for FormPickerMultiCheckBoxElement output string generation by foodpoison · Pull Request #188 · TheJuki/KFormMaster · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

added an override for FormPickerMultiCheckBoxElement output string generation #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2020
Merged

added an override for FormPickerMultiCheckBoxElement output string generation #188

merged 1 commit into from
May 22, 2020

Conversation

foodpoison
Copy link

Issue Link

This addresses my own feature request HERE

Goals

See the feature request.

Implementation Details

  • added a few more fruits and a new multiCheckBox block to test activity to illustrate my point, once you get past a certain size it doesn't make sense to show the full list. This is especially evident in some custom layouts, for example I'm stacking the Cell's title and value vertically, similar to how Android's system settings UI these days, where the value will only be in a single line.
  • was trying to follow the code in getSelectedItemsText(), seemed a bit long for what its trying to do, so replaced it with a short version with Kotlin collection functions.
  • changed displayNewValue back to using valueAsString so it seemed more consistent with the rest of the project, and made getSelectedItemsText() private.

Testing Details

Didn't add any new tests.

@codecov
Copy link
codecov bot commented May 22, 2020

Codecov Report

Merging #188 into master will decrease coverage by 0.23%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #188      +/-   ##
============================================
- Coverage     46.14%   45.91%   -0.24%     
+ Complexity      469      467       -2     
============================================
  Files            77       77              
  Lines          2763     2753      -10     
  Branches        896      892       -4     
============================================
- Hits           1275     1264      -11     
- Misses          979      980       +1     
  Partials        509      509
Impacted Files Coverage Δ Complexity Δ
...formmaster/model/FormPickerMultiCheckBoxElement.kt 55.95% <20.00%> (-5.75%) 24.00 <3.00> (-2.00)
...rmmaster/view/FormPickerMultiCheckBoxViewBinder.kt 65.00% <100.00%> (ø) 2.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c44e8ba...236f2dd. Read the comment docs.

@TheJuki
Copy link
Owner
TheJuki commented May 22, 2020

This looks good. Thanks!

@TheJuki TheJuki merged commit 6dea4f4 into TheJuki:master May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@foodpoison @TheJuki
0