Support NCNN_ISA environment variable detection #5687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54d7c94
to
c24a3cf
Compare
Changes: - Implemented `get_isa_env` function to retrieve and parse ISA flags from the environment variable. Signed-off-by: Kaiyao Duan <inspiremenow@murena.io>
c24a3cf
to
63d817c
Compare
Signed-off-by: Kaiyao Duan <inspiremenow@murena.io>
- Updated `get_isa_env` function to compare ISA flags without leading characters. - Changed the way ISA flags are checked for various architectures, removing the leading '-' for better clarity. - Update CPU feature checks to include base feature dependencies. Signed-off-by: Kaiyao Duan <inspiremenow@murena.io>
- Added environment detection tests to CMake configuration, setting ISA env flags based on the system architecture for Linux, Windows, Darwin, and Android. Signed-off-by: Kaiyao Duan <inspiremenow@murena.io>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5687 +/- ##
===========================================
- Coverage 94.07% 89.99% -4.08%
===========================================
Files 736 265 -471
Lines 229064 77480 -151584
===========================================
- Hits 215497 69730 -145767
+ Misses 13567 7750 -5817 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kaiyao Duan <inspiremenow@murena.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
get_isa_envfunction to retrieve and parse ISA flags from the environment variable.Signed-off-by: Kaiyao Duan inspiremenow@murena.io