Overhaul anubis.freebsd #427
Conversation
Some changes here to reflect the discussion in pull request 274 regarding the `anubis_env`, `anubis_env_file` and `anubis_args` variables. At the risk of improving personal choices in configuration with a minor amount more complexity, this new script now allows for the use of all three of these, together, with no interference between them all i.e. - if `anubis_env_file` is set, environment variables will be taken from this file - if `anubis_env` is set, environment variables will be taken from this string of variables, and override matching variables set in `anubis_env_file` - if `anubis_args` is set, runtime parameters will be taken from this string and override matching ones in both `anubis_env_file` and `anubis_env` Thanks to @dlangille for the advice with this. Signed-off-by: Paul Wilde <31094984+pswilde@users.noreply.github.com>
Signed-off-by: Paul Wilde <31094984+pswilde@users.noreply.github.com>
Signed-off-by: Paul Wilde <31094984+pswilde@users.noreply.github.com>
Signed-off-by: Paul Wilde <31094984+pswilde@users.noreply.github.com>
|
Last I checked things like env vars don’t get correctly passed through when using daemon, which is why the rc script in ports uses anubis_args instead of the more obvious anubis_flags. if these changes above work I should adopt them in the port … perhaps we should keep the rc script in one place rather than two? |
|
Yep, that's fair. I wrote the original PR ( #274 ) before I knew of your ports version, so I agree this is largely unecessary now. Anyway, very happy for ports to be the mainline, as it should be. Perhaps a note in docs to point people that way? |
Signed-off-by: Xe Iaso <me@xeiaso.net>
|
I'd be more than happy to have the ports version be the way we suggest for FreeBSD. Just make sure it's up to date! |
Some changes here to reflect the discussion in pull request 274 regarding the
anubis_env,anubis_env_fileandanubis_argsvariables. At the risk of improving personal choices in configuration with a minor amount more complexity, this new script now allows for the use of all three of these, together, with no interference between them all i.e.anubis_env_fileis set, environment variables will be taken from this fileanubis_envis set, environment variables will be taken from this string of variables, and override matching variables set inanubis_env_fileanubis_argsis set, runtime parameters will be taken from this string and override matching ones in bothanubis_env_fileandanubis_envThanks to @dlangille for the advice with this.
Checklist:
[Unreleased]section of docs/docs/CHANGELOG.mdnpm run test:integration(unsupported on Windows, please use WSL)