-
Notifications
You must be signed in to change notification settings - Fork 102
Closes #2378 - Add DeleteHistoryEvent for Task #2380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryzheboka
requested changes
Sep 15, 2023
...ana-common/src/main/java/pro/taskana/common/internal/util/ObjectAttributeChangeDetector.java
Show resolved
Hide resolved
...y-provider/src/test/java/acceptance/events/task/CreateHistoryEventOnTaskDeletionAccTest.java
Outdated
Show resolved
Hide resolved
ryzheboka
requested changes
Sep 21, 2023
...y-provider/src/test/java/acceptance/events/task/CreateHistoryEventOnTaskDeletionAccTest.java
Outdated
Show resolved
Hide resolved
...y-provider/src/test/java/acceptance/events/task/CreateHistoryEventOnTaskDeletionAccTest.java
Outdated
Show resolved
Hide resolved
lib/taskana-core/src/main/java/pro/taskana/task/internal/TaskServiceImpl.java
Outdated
Show resolved
Hide resolved
...y-provider/src/test/java/acceptance/events/task/CreateHistoryEventOnTaskDeletionAccTest.java
Show resolved
Hide resolved
...y-provider/src/test/java/acceptance/events/task/CreateHistoryEventOnTaskDeletionAccTest.java
Show resolved
Hide resolved
c44f44d
to
ab01e5b
Compare
ryzheboka
reviewed
Sep 21, 2023
...y-provider/src/test/java/acceptance/events/task/CreateHistoryEventOnTaskDeletionAccTest.java
Outdated
Show resolved
Hide resolved
ryzheboka
reviewed
Sep 21, 2023
...y-provider/src/test/java/acceptance/events/task/CreateHistoryEventOnTaskDeletionAccTest.java
Outdated
Show resolved
Hide resolved
80f8144
to
95c29f4
Compare
ryzheboka
reviewed
Oct 24, 2023
...y-provider/src/test/java/acceptance/events/task/CreateHistoryEventOnTaskDeletionAccTest.java
Outdated
Show resolved
Hide resolved
ryzheboka
reviewed
Oct 24, 2023
lib/taskana-core/src/main/java/pro/taskana/task/internal/TaskServiceImpl.java
Outdated
Show resolved
Hide resolved
72f4bfb
to
e4a81f0
Compare
ryzheboka
requested changes
Oct 24, 2023
lib/taskana-core/src/main/java/pro/taskana/spi/history/api/events/task/TaskDeletedEvent.java
Outdated
Show resolved
Hide resolved
lib/taskana-core/src/main/java/pro/taskana/task/internal/TaskServiceImpl.java
Show resolved
Hide resolved
ryzheboka
reviewed
Oct 24, 2023
...y-provider/src/test/java/acceptance/events/task/CreateHistoryEventOnTaskDeletionAccTest.java
Outdated
Show resolved
Hide resolved
ryzheboka
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a
2E09
valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://sonarcloud.io/summary/new_code?id=jamesrdi_taskana&branch=TSK-2378
Release Notes:
For the submitter:
Verified by the reviewer: