8000 Closes #2316 - refactor DmnTaskRouterAccTest to use test-api by jamesrdi · Pull Request #2317 · Taskana/taskana · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Closes #2316 - refactor DmnTaskRouterAccTest to use test-api #2317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Closes #2316 - refactor DmnTaskRouterAccTest to use test-api #2317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions routing/taskana-spi-routing-dmn-router/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,12 @@
<version>${version.oracle}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>pro.taskana</groupId>
<artifactId>taskana-test-api</artifactId>
<version>${project.version}</version>
<scope>test</scope>
</dependency>
</dependencies>

</project>
133 changes: 122 additions & 11 deletions ...na-spi-routing-dmn-router/src/test/java/pro/taskana/routing/dmn/DmnTaskRouterAccTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,29 +2,94 @@

import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatThrownBy;
import static pro.taskana.testapi.DefaultTestEntities.defaultTestClassification;
import static pro.taskana.testapi.DefaultTestEntities.defaultTestWorkbasket;

import java.lang.reflect.Field;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import org.assertj.core.api.ThrowableAssert.ThrowingCallable;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;
import pro.taskana.AbstractAccTest;
import pro.taskana.TaskanaConfiguration;
import pro.taskana.classification.api.ClassificationService;
import pro.taskana.classification.api.models.ClassificationSummary;
import pro.taskana.common.api.TaskanaEngine;
import pro.taskana.common.api.exceptions.InvalidArgumentException;
import pro.taskana.common.test.security.JaasExtension;
import pro.taskana.common.test.security.WithAccessId;
import pro.taskana.common.internal.InternalTaskanaEngine;
import pro.taskana.spi.routing.api.TaskRoutingProvider;
import pro.taskana.spi.routing.internal.TaskRoutingManager;
import pro.taskana.task.api.TaskService;
import pro.taskana.task.api.models.ObjectReference;
import pro.taskana.task.api.models.Task;
import pro.taskana.testapi.TaskanaInject;
import pro.taskana.testapi.TaskanaIntegrationTest;
import pro.taskana.testapi.WithServiceProvider;
import pro.taskana.testapi.builder.ObjectReferenceBuilder;
import pro.taskana.testapi.builder.UserBuilder;
import pro.taskana.testapi.builder.WorkbasketAccessItemBuilder;
import pro.taskana.testapi.builder.WorkbasketBuilder;
import pro.taskana.testapi.security.WithAccessId;
import pro.taskana.user.api.UserService;
import pro.taskana.workbasket.api.WorkbasketPermission;
import pro.taskana.workbasket.api.WorkbasketService;
import pro.taskana.workbasket.api.WorkbasketType;
import pro.taskana.workbasket.api.models.WorkbasketSummary;

@ExtendWith(JaasExtension.class)
class DmnTaskRouterAccTest extends AbstractAccTest {
@WithServiceProvider(
serviceProviderInterface = TaskRoutingProvider.class,
serviceProviders = DmnTaskRouter.class)
@TaskanaIntegrationTest
class DmnTaskRouterAccTest {
TaskanaConfiguration taskanaConfiguration;
@TaskanaInject TaskService taskService;
@TaskanaInject ClassificationService classificationService;
@TaskanaInject WorkbasketService workbasketService;
@TaskanaInject UserService userService;
@TaskanaInject TaskanaEngine taskanaEngine;
@TaskanaInject InternalTaskanaEngine internalTaskanaEngine;

private final TaskService taskService = taskanaEngine.getTaskService();
ClassificationSummary defaultClassificationSummary;
WorkbasketSummary defaultWorkbasketSummary;

@WithAccessId(user = "businessadmin")
@BeforeAll
void setup() throws Exception {
taskanaConfiguration = taskanaEngine.getConfiguration();
defaultClassificationSummary =
defaultTestClassification().buildAndStoreAsSummary(classificationService);
defaultWorkbasketSummary = defaultTestWorkbasket().buildAndStoreAsSummary(workbasketService);

createWorkbasketWithDomainA("GPK_KSC").buildAndStoreAsSummary(workbasketService);
createWorkbasketWithDomainA("GPK_KSC_1").buildAndStoreAsSummary(workbasketService);
createWorkbasketWithDomainA("GPK_KSC_2").buildAndStoreAsSummary(workbasketService);

WorkbasketAccessItemBuilder.newWorkbasketAccessItem()
.workbasketId(d 8000 efaultWorkbasketSummary.getId())
.accessId("user-1-2")
.permission(WorkbasketPermission.OPEN)
.permission(WorkbasketPermission.READ)
.permission(WorkbasketPermission.APPEND)
.buildAndStore(workbasketService);

UserBuilder.newUser()
.id("user-1-2")
.firstName("Max")
.lastName("Mustermann")
.longName("Long name of user-1-2")
.buildAndStore(userService);

changeDmnTable("/dmn-table.dmn");

reinitializeTaskRoutingProviders();
}

@WithAccessId(user = "taskadmin")
@Test
void should_RouteTaskToCorrectWorkbasket_When_DmnTaskRouterFindsRule() throws Exception {

Task taskToRoute = taskService.newTask();
taskToRoute.setClassificationKey("T2100");
taskToRoute.setClassificationKey(defaultClassificationSummary.getKey());
ObjectReference objectReference =
createObjectReference("company", null, null, "MyType1", "00000001");
taskToRoute.setPrimaryObjRef(objectReference);
Expand All @@ -36,9 +101,8 @@ void should_RouteTaskToCorrectWorkbasket_When_DmnTaskRouterFindsRule() throws Ex
@WithAccessId(user = "taskadmin")
@Test
void should_ThrowException_When_DmnTaskRouterFindsNoRule() {

Task taskToRoute = taskService.newTask();
taskToRoute.setClassificationKey("T2100");
taskToRoute.setClassificationKey(defaultClassificationSummary.getKey());
ObjectReference objectReference =
createObjectReference("company", null, null, "MyTeö", "000002");
taskToRoute.setPrimaryObjRef(objectReference);
Expand All @@ -49,4 +113,51 @@ void should_ThrowException_When_DmnTaskRouterFindsNoRule() {
.extracting(Throwable::getMessage)
.isEqualTo("Cannot create a Task outside a Workbasket");
}

ObjectReference createObjectReference(
String company, String system, String systemInstance, String type, String value) {
return ObjectReferenceBuilder.newObjectReference()
.company(company)
.system(system)
.systemInstance(systemInstance)
.type(type)
.value(value)
.build();
}

private void changeDmnTable(String newPath) throws Exception {
Map<String, String> mutableProperties = new HashMap<>();
String dmnTableProperty = "taskana.routing.dmn";
mutableProperties.put(dmnTableProperty, newPath);
Field property = taskanaConfiguration.getClass().getDeclaredField("properties");
property.setAccessible(true);
property.set(taskanaConfiguration, mutableProperties);
property.setAccessible(false);
}

private Object getProperty(String declaredField, Object object) throws Exception {
Field property = object.getClass().getDeclaredField(declaredField);
property.setAccessible(true);
Object returnObject = property.get(object);
property.setAccessible(false);
return returnObject;
}

private void reinitializeTaskRoutingProviders() throws Exception {
TaskRoutingManager taskRoutingManager = internalTaskanaEngine.getTaskRoutingManager();
List<TaskRoutingProvider> taskRoutingProviders =
(List<TaskRoutingProvider>) getProperty("taskRoutingProviders", taskRoutingManager);
for (TaskRoutingProvider taskRoutingProvider : taskRoutingProviders) {
taskRoutingProvider.initialize(taskanaEngine);
}
}

private WorkbasketBuilder createWorkbasketWithDomainA(String key) {
return WorkbasketBuilder.newWorkbasket()
.key(key)
.domain("DOMAIN_A")
.name("Megabasket")
.type(WorkbasketType.GROUP)
.orgLevel1("company");
}
}
20 changes: 20 additions & 0 deletions routing/taskana-spi-routing-dmn-router/src/test/resources/empty.dmn
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
<?xml version="1.0" encoding="UTF-8"?>
<definitions xmlns="https://www.omg.org/spec/DMN/20191111/MODEL/" xmlns:dmndi="https://www.omg.org/spec/DMN/20191111/DMNDI/" xmlns:dc="http://www.omg.org/spec/DMN/20180521/DC/" xmlns:modeler="http://camunda.org/schema/modeler/1.0" id="Definitions_0m4jljf" name="DRD" namespace="http://camunda.org/schema/1.0/dmn" exporter="Camunda Modeler" exporterVersion="5.12.1" modeler:executionPlatform="Camunda Cloud" modeler:executionPlatformVersion="8.2.0">
<decision id="workbasketRouting" name="Workbasket Routing">
<decisionTable id="workbasketRouting_decisionTable" hitPolicy="FIRST">
<input id="Input_1">
<inputExpression id="InputExpression_1" typeRef="string">
<text></text>
</inputExpression>
</input>
<output id="Output_1" typeRef="string" />
</decisionTable>
</decision>
<dmndi:DMNDI>
<dmndi:DMNDiagram>
<dmndi:DMNShape dmnElementRef="Decision_1e62yjv">
<dc:Bounds height="80" width="180" x="160" y="100" />
</dmndi:DMNShape>
</dmndi:DMNDiagram>
</dmndi:DMNDI>
</definitions>
2 changes: 1 addition & 1 deletion routing/taskana-spi-routing-dmn-router/src/test/resources/taskana.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ taskana.jobs.history.cleanup.runEvery=P1D
taskana.workingTime.holidays.german.enabled=true
taskana.workingTime.holidays.german.corpus-christi.enabled=true
taskana.history.logger.name=AUDIT
taskana.routing.dmn=/dmn-table.dmn
taskana.routing.dmn=/empty.dmn
# enable or disable the jobscheduler at all
# set it to false and no jobs are running
taskana.jobs.scheduler.enabled=false
Expand Down
0