fix(angular-query): fix injectInfiniteQuery to narrow type after isSuccess #9016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit 21b32a0.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9016 +/- ##
===========================================
+ Coverage 44.58% 86.16% +41.58%
===========================================
Files 203 17 -186
Lines 8104 318 -7786
Branches 1812 70 -1742
===========================================
- Hits 3613 274 -3339
+ Misses 4059 39 -4020
+ Partials 432 5 -427
🚀 New features to boost your workflow:
|
|
Merged, but it doesn't fully fix #8984 as it's not just |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed injectInfiniteQuery to narrow type after isSuccess.
Also, I wrote a test for this case.