8000 shift Rubyies in CI: 1.9 - 2.2 -> 2.3 - 3.0 by swiknaba · Pull Request #4 · TamerShlash/symbolized · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

shift Rubyies in CI: 1.9 - 2.2 -> 2.3 - 3.0 #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

shift Rubyies in CI: 1.9 - 2.2 -> 2.3 - 3.0 #4

wants to merge 1 commit into from

Conversation

swiknaba
Copy link
@swiknaba swiknaba commented Jan 3, 2021 •
edited
Loading

Shifts Ruby versions for CI from 1.9.3 - 2.2.2 to 2.3.8 - 3.0.0

2.3.8 is the oldest EOL version that you can still download on the official Ruby page.

Ruby 2.6 deprecated BigDecimal.new, hence specs for Ruby > 2.6 are failing with:

~/Sites/gems/symbolized/lib/symbolized/core_ext/object/duplicable.rb:86:in `<class:BigDecimal>': undefined method `new' for BigDecimal:Class (NoMethodError)
	from ~/Sites/gems/symbolized/lib/symbolized/core_ext/object/duplicable.rb:81:in `<top (required)>'
	from ~/Sites/gems/symbolized/lib/symbolized/core_ext/object/deep_dup.rb:2:in `require'
	from ~/Sites/gems/symbolized/lib/symbolized/core_ext/object/deep_dup.rb:2:in `<top (required)>'
	from ~/Sites/gems/symbolized/test/core_ext/hash_ext_test.rb:2:in `require'
	from ~/Sites/gems/symbolized/test/core_ext/hash_ext_test.rb:2:in `<top (required)>'
	from ~/.rbenv/versions/3.0.0/lib/ruby/gems/3.0.0/gems/rake-13.0.3/lib/rake/rake_test_loader.rb:17:in `require'
	from ~/.rbenv/versions/3.0.0/lib/ruby/gems/3.0.0/gems/rake-13.0.3/lib/rake/rake_test_loader.rb:17:in `block in <main>'
	from ~/.rbenv/versions/3.0.0/lib/ruby/gems/3.0.0/gems/rake-13.0.3/lib/rake/rake_test_loader.rb:5:in `select'
	from ~/.rbenv/versions/3.0.0/lib/ruby/gems/3.0.0/gems/rake-13.0.3/lib/rake/rake_test_loader.rb:5:in `<main>'

I've fixed that in a separate PR: #5

locally, specs are passing up until Ruby 2.6.6 ✅

53 runs, 219 assertions, 0 failures, 0 errors, 0 skips

@swiknaba swiknaba mentioned this pull request Jan 3, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@swiknaba
0