Add script for fetching Noto Sans font #931
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fonts are a bit of a messy issue. I haven't documented this anywhere but currently only the fonts I included in the exe bundle are the ones that are used. They are:
But other language versions won't be used. So importing every Noto font is unnecessary. Also I'm not entirely sure if they can be put in sub folders. I'm not entirely sure on all this, fontconfig is complicated, and even more complicated on Windows where the behavior is different. But I remember running into performance issues trying to load more fonts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build instruction for Windows has this manual step. This script automates getting the Noto Sans font from the source.
https://fonts.google.com/noto/specimen/Noto+Sans links to https://github.com/notofonts/noto-source, which then says to go to https://notofonts.github.io/.