8000 deprecate Dispatcher.php in favour of CommandControllers · Issue #18 · TYPO3-coreapi/ext-coreapi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Aug 15, 2023. It is now read-only.

deprecate Dispatcher.php in favour of CommandControllers #18

Closed
etobi opened this issue Jul 8, 2013 · 3 comments
Closed

deprecate Dispatcher.php in favour of CommandControllers #18

etobi opened this issue Jul 8, 2013 · 3 comments
Assignees
@Konafets
Labels
enhancement
Milestone
1.0.0

Comments

@etobi
Copy link
Member
etobi commented Jul 8, 2013

currently some code is duplicated in the Dispatcher.php and the extbase-driven CommandControllers.
I really like to get rid of the Dispatcher.php thing as soon as 4.5 is not supported anymore and encourage people to use the CommandControllers (available from 4.7+)

So if using the Dispatcher in >=4.7 should output a warning and log in the deprecation log.
@madsbrunn
Copy link

An idea:

add own version of Tx_Extbase_MVC_Controller_CommandController to ext_autoload.php if TYPO3 version < 4.7.x

Then we can instantiate the command controllers from Dispatcher.php and avoid a lot of duplicated code.

@etobi
Copy link
Member Author
etobi commented Jul 11, 2013

I would love to see this. I recently tried to start the Extbase Command Controllers from the Dispatcher, but didn't found an easy (and correct) way without a lot hassle or down sides.

@madsbrunn
Copy link

While we are at it I suggest normalizing the signature for the coreapi < 4.7 dispatcher and the extbase command controllers.

Right now we have:

./cli_dispatch_phpsh coreapi site:info
and
./cli_dispatch_phpsh extbase siteapi:info

??
Why not use

./cli_dispatch_phpsh coreapi site:info
./cli_dispatch_phpsh extbase site:info

or

./cli_dispatch_phpsh coreapi siteapi:info
./cli_dispatch_phpsh extbase siteapi:info

Maybe this belongs in a new issue?

@etobi etobi mentioned this issue Jul 12, 2013
Closed
Konafets pushed a commit that referenced this issue Jun 4, 2014
Add support for TYPO3 6.2 and drop support for all other version below
ed0a546 
* Introduce namespaces
* Adjust doc comments
* Remove closing php tag
* Fix typo
* Remove the legacy Dispatcher interface

Close #18
Close #47
Konafets pushed a commit that referenced this issue Jun 4, 2014
Add support for TYPO3 6.2 and drop support for all other version below
54d6f82 
* Introduce namespaces
* Adjust doc comments
* Remove closing php tag
* Fix typo
* Remove the legacy Dispatcher interface

close #18
close #47
@Konafets Konafets added this to the Make coreapi compatible to TYPO3 CMS 6.2 milestone Jun 4, 2014
@Konafets Konafets closed this as completed Jun 4, 2014
Konafets pushed a commit that referenced this issue Jun 11, 2014
Add support for TYPO3 6.2 and drop support for all other version below
e339ef2 
* Introduce namespaces
* Adjust doc comments
* Remove closing php tag
* Fix typo
* Remove the legacy Dispatcher interface

close #18
close #47
@Konafets Konafets self-assigned this Jun 29, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Konafets Konafets

Labels
enhancement
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
3 participants
@etobi @madsbrunn @Konafets
0