feat(aws-eks-asg-rolling-update-handler): Add option to create PodMonitor #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need this in order to use a PodMonitor like this: apiVersion: monitoring.coreos.com/v1
kind: PodMonitor
metadata:
name: rolling-update-handler-metrics
spec:
selector:
matchLabels:
app.kubernetes.io/name: aws-eks-asg-rolling-update-handler
podMetricsEndpoints:
- port: metrics |
TwiN
requested changes
Jan 3, 2024
d2413a1 to
64e92fc
Compare
|
sure :) |
4b8e14e to
4153b57
Compare
TwiN
requested changes
Feb 22, 2025
| @@ -33,6 +33,14 @@ spec: | |||
| dnsPolicy: Default | |||
| containers: | |||
| - name: {{ template "aws-eks-asg-rolling-update-handler.name" . }} | |||
| {{- range .Values.environmentVars }} | |||
| {{- if eq .name "METRICS_PORT" }} | |||
There was a problem hiding this comment.
I've never seen this kind of pattern, and I'm not really a fan. I'd rather have a clear variable for the chart.
Something like
metrics:
enabled: true
port: 8080| @@ -0,0 +1,18 @@ | |||
| {{- if .Values.podmonitor.create }} | |||
There was a problem hiding this comment.
Suggested change
| {{- if .Values.podmonitor.create }} | |
| {{- if .Values.podMonitor.create }} |
| @@ -49,3 +49,8 @@ containerSecurityContext: {} | |||
| # capabilities: | |||
| # drop: | |||
| # - ALL | |||
|
|
|||
| podmonitor: | |||
There was a problem hiding this comment.
Suggested change
| podmonitor: | |
| podMonitor: |
| @@ -14,3 +14,4 @@ The following table lists the configurable parameters of the aws-eks-asg-rolling | |||
| | podLabels | Labels to add to the aws-eks-asg-rolling-update-handler pod configuration | no | `{}` | | |||
| | securityContext | Pod security context | no | `{}` | | |||
| | containerSecurityContext | Container security context | no | `{}` | | |||
| | podmonitor | Create a PodMonitor | no | `{"create": false, "labels": {}}` | | |||
There was a problem hiding this comment.
Suggested change
| | podmonitor | Create a PodMonitor | no | `{"create": false, "labels": {}}` | | |
| | podMonitor | Create a PodMonitor | no | `{"create": false, "labels": {}}` | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
this enables usage of PodMonitor CustomResource in kube-prometheus-stack and it opens the possibility of port-forwarding.
In my opinion this shouldnt be notable in existing deployments.
Checklist
README.md, if applicable.