BED-5435 AddSelf, BED-5988 Mandatory Filters #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…id, which is a valid attack for this scenario fix: Make our ldap filters actually respect mandatory filters properly https://specterops.atlassian.net/browse/BED-5435
…riate and not added if not
MikeX777
reviewed
Jun 6, 2025
definitelynotagoblin
approved these changes
Jun 6, 2025
MikeX777
approved these changes
Jun 6, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BED-5435:
AddSelf edge creation was happening when user has ACE GUID WriteMember but another way AddSelf can be used is when a user has an ACE GUID 00000000-0000-0000-0000-000000000000 (AllGuid)
BED-5988:
Include mandatory filters in each filter retrieved from GetFilterList()
Motivation and Context
https://specterops.atlassian.net/browse/BED-5435
https://specterops.atlassian.net/browse/BED-5988
How Has This Been Tested?
BED-5435:
Set up user to have ACE GUID 00000000-0000-0000-0000-000000000000 and give them
Add/Remove self as memberto a group. Run a collection and search in BH/BHE and see thatAddSelfedge is shown from user to group.BED-5988:
Screenshots (if appropriate):
Types of changes
Checklist: