Improve special identities coverage #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktstrader
approved these changes
Jun 9, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add additional well-known SIDs
SIDs removed from the ACL SID filter:
SIDs added to the filter:
Motivation and Context
We want to include all well-known SIDs so we can resolve their names in BloodHound.
The ACL SID filter should only filter out permissions that are irrelevant from an abuse perspective. IUSR is a local service on DCs and therefore only interesting from local privilege escalation perspective, which BloodHound currently does not cover. The two SIDs now excluded from the filter can (potentially) be abused remotely.
Resolves BP-499
How Has This Been Tested?
Ran it locally in lab.
See result in this PR: SpecterOps/BloodHound#1529
Types of changes
Checklist: