8000 [BED-5934] First pass to provide better SMB Signing query transparency in logging by definitelynotagoblin · Pull Request #206 · SpecterOps/SharpHoundCommon · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[BED-5934] First pass to provide better SMB Signing query transparency in logging #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 9, 2025
Merged

[BED-5934] First pass to provide better SMB Signing query transparency in logging #206

merged 10 commits into from
Jun 9, 2025

Conversation

definitelynotagoblin
Copy link
Contributor
@definitelynotagoblin definitelynotagoblin commented May 28, 2025 •
edited
Loading

Description

Provide trace logging for SMB info scanning to provide more visibility into query paths taken to get this data.
Add additional safety check to SMB2 response parsing to add further confidence that the packet returned is properly composed.

Motivation and Context

BED-5934

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

@definitelynotagoblin definitelynotagoblin self-assigned this May 28, 2025
@definitelynotagoblin definitelynotagoblin changed the title [BED-5934] First pass to provide better SMB Signing query behaviors in logging [BED-5934] First pass to provide better SMB Signing query transparency in logging May 28, 2025
definitelynotagoblin
definitelynotagoblin commented May 28, 2025
View reviewed changes
definitelynotagoblin
definitelynotagoblin commented May 30, 2025
View reviewed changes
definitelynotagoblin
definitelynotagoblin commented May 30, 2025
View reviewed changes
ktstrader
ktstrader reviewed Jun 9, 2025
View reviewed changes
@definitelynotagoblin definitelynotagoblin merged commit 801f2c5 into v4 Jun 9, 2025
3 checks passed
@definitelynotagoblin definitelynotagoblin deleted the BED-5934 branch June 9, 2025 20:08
@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ktstrader ktstrader ktstrader approved these changes

Assignees

@definitelynotagoblin definitelynotagoblin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@definitelynotagoblin @ktstrader
0