8000 fix playbar container background and tweak category header by NeoNyaa · Pull Request #52 · SpaceTheme/Steam · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix playbar container background and tweak category header #52

New issue

Have a question about 10000 this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 19, 2025
Merged

fix playbar container background and tweak category header #52

merged 5 commits into from
Feb 19, 2025

Conversation

NeoNyaa
Copy link
Contributor
@NeoNyaa NeoNyaa commented Feb 19, 2025

Changes made

  • Fixed the blue gray peeking from behind the top left corner
  • Improved the text alignment of category headers
  • Improved the hovering of long category header names (by complete accident)

Before

Play Bar Container Before
Slight blue gray peaking out from top left corner

Category Header Before
The name of the category sits way too high and looks out of place

Category Header Hover Before
The background of the category name peaks out from under the category name hover background

After

Play Bar Container After
Play Bar Container Hover After
Category Header After

SpaceEnergy
SpaceEnergy requested changes Feb 19, 2025
View reviewed changes
Copy link
Member
@SpaceEnergy SpaceEnergy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the changes and then it will look good for me

src/css/steam/gamepage.css Outdated
@@ -124,6 +124,7 @@


._3DeO92O5aVkcdwEBCJDjWm._3fLo166MlaNqP8r8tTyRz {
background: none !important;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unnecessary because background: unset; is already inside

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didnt notice the background unset

src/css/steam/sidebar.css
@@ -232,7 +232,21 @@
border-radius: 8px;
background: none;
background-color: rgb(var(--color-1));
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls fix format

@SpaceEnergy SpaceEnergy self-assigned this Feb 19, 2025
@SpaceEnergy
Copy link
Member

and because of "Fixed the blue gray peeking from behind the top left corner" you should update the theme

NeoNyaa
NeoNyaa commented Feb 19, 2025
View reviewed changes
Copy link
Contributor Author
@NeoNyaa NeoNyaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the formatting and added !important to the unset

Didnt notice the formatting was all bad as usually I use 2 space indentation and I also didnt notice the unset at the time

src/css/steam/gamepage.css Outdated
@@ -124,6 +124,7 @@


._3DeO92O5aVkcdwEBCJDjWm._3fLo166MlaNqP8r8tTyRz {
background: none !important;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didnt notice the background unset

@NeoNyaa
Copy link
Contributor Author
NeoNyaa commented Feb 19, 2025 •
edited
Loading

and because of "Fixed the blue gray peeking from behind the top left corner" you should update the theme

I only just installed the theme yesterday so that blue gray was there on the latest version

Initially installed via millenium but when making changes opted for git reset --hard to make sure i was editing the latest of the latest and the blue gray was still present

@SpaceEnergy
Copy link
Member

and because of "Fixed the blue gray peeking from behind the top left corner" you should update the theme

I only just installed the theme yesterday so that blue gray was there on the latest version

Initially installed via millenium but when making changes opted for git reset --hard to make sure i was editing the latest of the latest and the blue gray was still present

hmm wierd

SpaceEnergy
SpaceEnergy approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member
@SpaceEnergy SpaceEnergy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@SpaceEnergy SpaceEnergy merged commit 0424364 into SpaceTheme:main Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpaceEnergy SpaceEnergy SpaceEnergy approved these changes

Assignees

@SpaceEnergy SpaceEnergy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NeoNyaa @SpaceEnergy
0