8000 UI: Update jQuery to 1.11.3 by brgaulin · Pull Request #901 · Sonarr/Sonarr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

UI: Update jQuery to 1.11.3 #901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2015
Merged

UI: Update jQuery to 1.11.3 #901

merged 1 commit into from
Nov 16, 2015

Conversation

brgaulin
Copy link

Just a simple version bump to jQuery. Fixes an IOS bug in 8.2 and 8.3

@brgaulin
Copy link
Author

Hello Sonarr Team!

As part of Hacktober, I was poking around repos of OS software I have seen before, and noticed your UI might want a little love =) I am a javascript developer in the US and would love to help out(much more than this little change). I was wondering if there was a UI punchlist?

Things I see so far:

  • Move from RequireJS to Webpack/CommonJS completely
  • Upgrade all the vendor libraries, integrate bower(was wondering if there was a reason for the old versions, or just they were new at the time?)
  • Minify assets for deployment, and use the already uglified vendor files
  • Probably many more.

But I have some bandwidth and over the next few months I would love to he 8000 lp out in any way =) Let me know

@markus101
Copy link
Member

Thanks for reaching out.

Move from RequireJS to Webpack/CommonJS completely

Is there a particular part where this wasn't done? We definitely intended to overhaul everything when it was converted and I haven't seen any cases where it was missed that I recall.

Upgrade all the vendor libraries, integrate bower(was wondering if there was a reason for the old versions, or just they were new at the time?)

We've updated a number of the libraries in some other UI changes we've been working on (much larger than dependency updates). We've looked at bower before (and used it professionally), but we haven't really considered adding it to Sonarr, as we tend to version lock things to make sure we're not breaking something, though automatically fetching libraries is certainly helpful.

Minify assets for deployment, and use the already uglified vendor files

This is already done as part of the build process.

@brgaulin
Copy link
Author

Sounds good! As far as the minify, when I start Sonarr, at least the vendor files are all unminified. So there may be a bug there. 

--Brendan Gaulin

(508) 728-3582

On Fri, Oct 30, 2015 at 1:09 AM, Mark McDowall notifications@github.com
wrote:

Thanks for reaching out.

Move from RequireJS to Webpack/CommonJS completely
Is there a particular part where this wasn't done? We definitely intended to overhaul everything when it was converted and I haven't seen any cases where it was missed that I recall.
Upgrade all the vendor libraries, integrate bower(was wondering if there was a reason for the old versions, or just they were new at the time?)
We've updated a number of the libraries in some other UI changes we've been working on (much larger than dependency updates). We've looked at bower before (and used it professionally), but we haven't really considered adding it to Sonarr, as we tend to version lock things to make sure we're not breaking something, though automatically fetching libraries is certainly helpful.
Minify assets for deployment, and use the already uglified vendor files

This is already done as part of the build process.

Reply to this email directly or view it on GitHub:
#901 (comment)

@markus101
Copy link
Member

At the moment we don't minify it, I was mistaken before, I'll let @kayone comment, but we may want to minify vendor.js, but we previously didn't see massive transfer gains since its gzipped from the server.

markus101 added a commit that referenced this pull request Nov 16, 2015
@markus101
Merge pull request #901 from brgaulin/jquery_upgrade
554c81f 
Update jQuery to 1.11.3
@markus101 markus101 merged commit 554c81f into Sonarr:develop Nov 16, 2015
@markus101
Copy link
Member

Sorry for the delay, if you're interested in helping out on the UI side send us an email to hello at sonarr.tv and we can give you some ideas on where we're going with things.

ta264 pushed a commit to ta264/Sonarr that referenced this pull request Dec 5, 2019
@RossValler @onedr0p
Fix/implement Webhook notifications (Sonarr#901)
3dc9d3a
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brgaulin @markus101
0