8000 feat: add f32 feature by jeyum2 · Pull Request #48 · Sollimann/bonsai · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: add f32 feature #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2025
Merged

feat: add f32 feature #48

merged 1 commit into from
Mar 6, 2025

Conversation

jeyum2
Copy link
Contributor
@jeyum2 jeyum2 commented Mar 5, 2025
  • Add f32 feature
  • f64 as default precision
  • Use Float type for f32 and f64

@jeyum2
Copy link
Contributor Author
jeyum2 commented Mar 5, 2025

examples has not been updated yet.
If you confirm this approach, I will update examples as well

@andriyDev
Copy link
Collaborator

LGTM, please update the examples!

@jeyum2 jeyum2 force-pushed the feat-f32 branch 2 times, most recently from 3634102 to 8c8f3e1 Compare March 5, 2025 23:47
@jeyum2 jeyum2 marked this pull request as ready for review March 5, 2025 23:47
@jeyum2
feat: add f32 feature
426d065 
- Add `f32` feature
- f64 as default precision
- Use `Float` type for `f32` and `f64`
@jeyum2 jeyum2 requested a review from andriyDev March 6, 2025 00:38
@jeyum2
Copy link
Contributor Author
jeyum2 commented Mar 6, 2025

Updated. 😄

@andriyDev andriyDev merged commit 27494b6 into Sollimann:main Mar 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andriyDev andriyDev andriyDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeyum2 @andriyDev
0