fix: action trigger settings ui previews #1309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stances` publication
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release52 #1309 +/- ##
=============================================
+ Coverage 60.61% 60.67% +0.06%
=============================================
Files 459 461 +2
Lines 78733 78872 +139
Branches 4849 5055 +206
=============================================
+ Hits 47721 47855 +134
+ Misses 30871 30780 -91
- Partials 141 237 +96 ☔ View full report in Codecov by Sentry. |
be4ea19 to
005a0e5
Compare
7 tasks
jstarpl
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the Contributor
This pull request is posted on behalf of the BBC
Type of Contribution
This is a: Bug fix
Current Behavior
When using the 'Action Triggers' settings page, it would not correctly show previews related to the current segment.
This was due to the ui subscribing to the 'parts' collection, but then using the 'uiparts' collection.
Q) should this be using parts or ui parts? I want to say parts as this is a settings page, but its trying to match playout behaviour so maybe should be using uiparts? it only needs the document ids, so it probably doesn't matter.
Additionally, when performing a take, this would not be reflected correctly in this ui, the tracker hook was missing a dependency.
I also found that the uiPartInstances publication had a rundownIds parameter that was unused by the publication implementation. This would cause the publication to be restarted unnecessarily, so has been removed.
Testing
Affected areas
This PR affects the Action Triggers settings ui
Time Frame
Other Information
Status