8000 New `enum novas_refraction_model` values. by attipaci · Pull Request #186 · Smithsonian/SuperNOVAS · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

New enum novas_refraction_model values. #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025
Merged

New enum novas_refraction_model values. #186

merged 1 commit into from
May 14, 2025

Conversation

attipaci
Copy link
Collaborator
@attipaci attipaci commented May 12, 2025

Added:

  • NOVAS_RADIO_REFRACTION to use the Berman & Rockwell 1972 radio refraction model.
  • NOVAS_WAVE_REFRACTION to use the IAU / SOFA wavelength-dependent refraction model. (The wavelength can be set via novas_refract_wavelength())

Also, tweaks to error propagation...

@attipaci attipaci added this to the 1.4.0 milestone May 12, 2025
@attipaci attipaci self-assigned this May 12, 2025
@attipaci attipaci added the enhancement New feature or request label May 12, 2025
Copy link
codecov bot commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.91%. Comparing base (a1e013b) to head (538d07c).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #186   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files          23       23           
  Lines        4588     4602   +14     
  Branches      851      856    +5     
=======================================
+ Hits         4584     4598   +14     
  Partials        4        4           
Flag Coverage Δ
unittests 99.91% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/refract.c 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1e013b...538d07c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@attipaci attipaci force-pushed the refract-enums branch 9 times, most recently from ffc9183 to c920686 Compare May 12, 2025 11:39
@attipaci attipaci changed the title Add more options to novas_refraction_model enum. Added enum novas_refraction_model values. May 12, 2025
@attipaci attipaci marked this pull request as ready for review May 12, 2025 11:40
@attipaci attipaci changed the title Added enum novas_refraction_model values. New enum novas_refraction_model values. May 14, 2025
@attipaci attipaci merged commit 6217bdf into main May 14, 2025
18 checks passed
@attipaci attipaci deleted the refract-enums branch May 14, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0