Label assignment mechanism refactor #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootkowsky
requested changes
Sep 26, 2019
| import {saveAs} from "file-saver"; | ||
| import {ImageRepository} from "../imageRepository/ImageRepository"; | ||
| import {LabelsSelector} from "../../store/selectors/LabelsSelector"; | ||
| import {ExporterUtil} from "../../utils/ExporterUtil"; | ||
| import * as _ from "lodash"; |
There was a problem hiding this comment.
tak nie importuj bo Ci się cały lodash dołącza do bundla
There was a problem hiding this comment.
w innych plikach też popraw
| }; | ||
| const labelName: LabelName = _.findLast(labelNames, {id: label.labelId}); | ||
| if (!!labelName) { | ||
| data[`${index}`] = { |
There was a problem hiding this comment.
skoro index jest typu number, to dlaczego robisz to w taki sposób z backtickami?
| const image: HTMLImageElement = ImageRepository.getById(imageData.id); | ||
| const labelRectsString: string[] = imageData.labelRects.map((labelRect: LabelRect) => { | ||
| const labelFields = [ | ||
| labelRect.labelIndex + "", | ||
| _.findIndex(labelNames, {id: labelRect.labelId}) + "", |
There was a problem hiding this comment.
dodajesz pustego stringa po co? żeby skonwertowało do stringa? jeśli tak to nie lepiej .toString()?
| } | ||
|
|
||
| &:not(.disabled):hover { | ||
| filter: brightness(35%) sepia(100%) hue-rotate(172deg) saturate(2000%); // fallback if new css variables are not supported by browser |
There was a problem hiding this comment.
ostatnio Ci powiedziałem że to jest fallback i to powinno działać xD ale chyba mi nie działało ostatnio xD
to tylko tak informacyjnie :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.