8000 fix logic of detection section by CheraghiMilad · Pull Request #5457 · SigmaHQ/sigma · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix logic of detection section #5457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix logic of detection section #5457

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions rules/linux/auditd/lnx_auditd_find_cred_in_files.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ status: test
description: 'Detecting attempts to extract passwords with grep'
references:
- https://github.com/redcanaryco/atomic-red-team/blob/f339e7da7d05f6057fdfcdd3742bfcf365fee2a9/atomics/T1552.001/T1552.001.md
author: 'Igor Fits, oscd.community'
author: Igor Fits, oscd.community, Milad Cheraghi
date: 2020-10-15
modified: 2023-04-30
modified: 2025-06-03
tags:
- attack.credential-access
- attack.t1552.001
Expand All @@ -16,11 +16,12 @@ logsource:
detection:
selection:
type: 'EXECVE'
keywords:
'|all':
- 'grep'
- 'password'
condition: selection and keywords
a0: 'grep'
a1: '--color=auto' # Is Alias
a2: '-ri'
a3: 'password'
a4: '/'
Comment on lines +19 to +23
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not fix the logic but make it more strict and will not match different orders of args.

The reason you did not get a match is probably due to a backend issue when converting the rule. Because a keyword rule should match all strings present on the log.

Since both the original and change contain the required strings, this does not improve the detections but makes it compatible with auditd. But as I said you are now hardcoding arg order.

So the change does not make sense. Please explain your reasoning?

condition: selection
falsepositives:
- Unknown
level: high
level: medium
Loading
0