Implement wallet lock/unlock utxos #1896
Open
+262
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements UTXO wallet locking and unlocking functionality to support the SingleAddressStore interface.
- Adds new methods in the SQLStore for locking, querying, and releasing UTXOs.
- Introduces corresponding database migration scripts and updates schema for both SQLite and MySQL.
- Implements test cases for wallet lock/unlock behavior.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| stores/wallet_test.go | Adds testing for wallet lock/unlock functionality. |
| stores/wallet.go | Implements LockUTXOs, LockedUTXOs, and ReleaseUTXOs methods. |
| stores/sql/sqlite/migrations/main/schema.sql | Adds schema for wallet_locked_outputs in SQLite. |
| stores/sql/sqlite/migrations/main/migration_00036_wallet_locked_utxos.sql | Migration script for creating wallet_locked_outputs (SQLite). |
| stores/sql/sqlite/main.go | Implements SQLite-specific lock, query, and release functions. |
| stores/sql/mysql/migrations/main/schema.sql | Adds schema for wallet_locked_outputs in MySQL. |
| stores/sql/mysql/migrations/main/migration_00036_wallet_locked_utxos.sql | Migration script for creating wallet_locked_outputs (MySQL). |
| stores/sql/mysql/main.go | Implements MySQL-specific lock, query, and release functions. |
| stores/sql/main.go | Provides common SQL functions for wallet locked outputs. |
| stores/sql/database.go | Updates the interface to include new UTXO lock/unlock methods. |
| internal/sql/migrations.go | Registers the new migration for wallet_locked_utxos. |
| .changeset/extend_store_with_utxo_lockunlock_methods_to_implement_the_singleaddressstore_interface.md | Contains changeset summary for new methods. |
...t/extend_store_with_utxo_lockunlock_methods_to_implement_the_singleaddressstore_interface.md
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,9 @@ | |||
| CREATE TABLE `wallet_locked_outputs` ( | |||
There was a problem hiding this comment.
Blocker to make sure these were manually verified
There was a problem hiding this comment.
verified manually, tested on both SQLite and MySQL - decided to change the identifier though 👍
459ae34 to
becf82a
Compare
a83406d to
841c9ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be app
2CD9
lied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blocked until SiaFoundation/coreutils#245 gets merged and we can fix the coreutils dependency to a version